Deduplicate Active Record reflection names #35921
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading some memory profiles I noticed some common string duplication in Reflection:
Unsurprisingly that
361
maps to the number ofbelongs_to :shop
we have. So since that string is effectively used as a symbol, I think it makes sense to freeze and deduplicate it, also since it's derived from model names, it's likely to be used across Rails and the application codebase.This won't be a huge saving, even for bigger apps, but it's also a very simple one to implement so it might be worth it.
@rafaelfranca @Edouard-chin