make SQLite3 last_inserted_id private and organize DatabaseStatement methods
#35922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…qlite3::DatabaseStatements and make those that are private in Abstract::DatabaseStatements private for sqlite3
michaelglass
changed the title
last_inserted_id private and organize DatabaseStatement methods
|
Thank you! |
michaelglass
deleted the
move-sqlite-3-database-statements-into-database-statements
branch
kamipo
added a commit
that referenced
this pull request
May 21, 2019
Almost all database statements methods except `explain` was moved into `DatabaseStatements` at #35922. This moves the last one method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR
Sqlite3::DatabaseStatementmodule if they're also in theAbstract::DatabaseStatementmodule.last_inserted_idprivateThe inspiration for this change was that when upgrading our
live_fixturesgem to rails 5, tests passed when running against sqlite3, but when consuming the gem in a mysql database, the tests failed. This was becauselast_inserted_idwas a private method for mysql.If the first part of the change is considered "cosmetic" I'm happy to revert it. I think it's a good idea to make
last_inserted_idprivate, though.