AS::Callbacks._define_runner better abstraction #3593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incapsulate the logic of keyed callback method definition and execution in the separated method.
josevalim
added a commit
that referenced
this pull request
Nov 10, 2011
AS::Callbacks._define_runner better abstraction
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_define_runnermethod can be improved by moving:"_run__#{self.class.name.hash.abs}__#{kind}__#{key.hash.abs}__callbacks"into separated method and make use of it in one place.
Now the logic of keyed callback method definition and execution is in the separated method.
Checked tests for AS and AR - all pass.