Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not execute rails app:update in railties/test/generators/app_generator_test.rb #35967

Merged

Conversation

ryohashimoto
Copy link
Contributor

@ryohashimoto ryohashimoto commented Apr 13, 2019

Summary

In railties/test/generators/app_generator_test.rb test file, system("bin/rails app:update") is called several times.
Like other test cases in the test file, it is enough to call Rails::AppGenerator#update_config_files .

@rails-bot rails-bot bot added the railties label Apr 13, 2019
@ryohashimoto ryohashimoto force-pushed the do_not_app_update_in_app_generator_test branch from 8651b58 to 80b74d0 Compare April 13, 2019 13:55
@ryohashimoto
Copy link
Contributor Author

ryohashimoto commented Apr 13, 2019

In this test case, still rails app:update need to be executed because Rails.application.config.loaded_config_version need to be obtained from loaded rails application.

@ryohashimoto ryohashimoto force-pushed the do_not_app_update_in_app_generator_test branch from 80b74d0 to c1a5c18 Compare April 13, 2019 14:27
@ryohashimoto ryohashimoto force-pushed the do_not_app_update_in_app_generator_test branch from c1a5c18 to da6dc41 Compare April 13, 2019 14:44
@y-yagi y-yagi merged commit 3a67d9b into rails:master Apr 15, 2019
@y-yagi
Copy link
Member

y-yagi commented Apr 15, 2019

Thanks!

@ryohashimoto ryohashimoto deleted the do_not_app_update_in_app_generator_test branch April 15, 2019 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants