Ensure multiple anonymous modules are not included into test classes #35968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
force-pushed
the
apply_acceptance_validator_to_subclasses_in_tests
branch
from
5381e29
to
a50629a
Compare
|
Just as a note: I don't think the pattern of including modules each time |
shioyama
changed the title
Each acceptance validator applied to a model class includes an instance of a module builder (LazilyDefineAttributes) into that class. In tests, if the original model class is not subclassed, these modules pile up and cannot be removed, potentially leading to flakey specs and false positive/negatives. To avoid this, always use subclasses in tests whose names (constants) can be removed when the test is done.
shioyama
force-pushed
the
apply_acceptance_validator_to_subclasses_in_tests
branch
from
a50629a
to
2e27801
Compare
This was referenced Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #35966. By the end of the tests here, the
Topicclass has something like five modules included in it. That doesn't seem like a very good idea.I've used named subclasses then cleaned up by removing the constant, which is not ideal but better than polluting the original class.