mounted routes with non-word characters #35975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Apr 15, 2019
mounted routes with non-word characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #35786, a regression introduced by ccc0597.
There are two special cases for which routing is broken:
/then paths that start with a non-word character don't work (eg./~foo)./engine*) then all routes to the engine don't work.The underlying problem is that in those cases routes to the engine don't have a word boundary after the part where the engine is mounted (between
/and~in/~fooand between*and/in/engine*/foo).#1 is handled by a conditional. #2 is solved with an additional lookahead check for
/in the regex.