Fix Bcc header missing with emails from conductor and test helpers

[jduff]

Summary

Bcc header was not being included with emails created by the actionmailbox conductor or the create_inbound_email_from test helpers. This change marks the Bcc header to be included when the email is encoded in both of those cases, using the include_in_headers features from the mail gem found here

[kaspth]

Since this line isn't in create_and_extract_message_id! will that mean Action Mailbox can't capture any BCC fields in emails?

[kaspth]

Is there an option we can pass to Mail.new in new_mail instead? Besides new_mail seems like the more suitable place for this.

[jduff]

Thanks for taking a look @kaspth!

Since this line isn't in create_and_extract_message_id! will that mean Action Mailbox can't capture any BCC fields in emails?

The only reason this is a problem in these two places is because a Mail object is initialized and then serialized with to_s before passing it along, that doesn't occur with the other services afaik since the raw data forwarded by the service is stored without creating a Mail object first (I only tested with Mailgun which included the Bcc header correctly).

Is there an option we can pass to Mail.new in new_mail instead? Besides new_mail seems like the more suitable place for this.

The only reference I found to include_in_headers is within the Bcc field itself so I don't think it can be passed through Mail.new. Putting this in new_mail does seem suitable, I'll update the PR with that change.

[jduff]

@kaspth are there any other changes that I should make to this before it can be merged?

[rafaelfranca]

Hey @jduff can you rebase this? We applied aab9f67 but I think we still need the change in the test helper.

[jduff]

@rafaelfranca I just rebased and pushed it up. I think the commit you referenced updated tests so if you want me to drop the tests I added as well let me know.