Deprecate where.not working as NOR and will be changed to NAND in Rails 6.1
#36029
+118
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails 6.1 `where.not` with polymorphic association is partly fixed incidentally at 213796f (refer rails#33493, rails#26207, rails#17010, rails#16983, rails#14161), and I've added test case e9ba12f to avoid lose that fix accidentally in the future. In Rails 5.2, `where.not(polymorphic: object)` works as expected as NAND, but `where.not(polymorphic_type: object.class.polymorphic_name, polymorphic_id: object.id)` still unexpectedly works as NOR. To will make `where.not` working desiredly as NAND in Rails 6.1, this deprecates `where.not` working as NOR. If people want to continue NOR conditions, we'd encourage to them to `where.not` each conditions manually. ```ruby all = [treasures(:diamond), treasures(:sapphire), cars(:honda), treasures(:sapphire)] assert_equal all, PriceEstimate.all.map(&:estimate_of) ``` In Rails 6.0: ```ruby sapphire = treasures(:sapphire) nor = all.reject { |e| e.estimate_of_type == sapphire.class.polymorphic_name }.reject { |e| e.estimate_of_id == sapphire.id } assert_equal [cars(:honda)], nor without_sapphire = PriceEstimate.where.not( estimate_of_type: sapphire.class.polymorphic_name, estimate_of_id: sapphire.id ) assert_equal nor, without_sapphire.map(&:estimate_of) ``` In Rails 6.1: ```ruby sapphire = treasures(:sapphire) nand = all - [sapphire] assert_equal [treasures(:diamond), cars(:honda)], nand without_sapphire = PriceEstimate.where.not( estimate_of_type: sapphire.class.polymorphic_name, estimate_of_id: sapphire.id ) assert_equal nand, without_sapphire.map(&:estimate_of) ``` Resolves rails#31209.
kamipo
force-pushed
the
deprecate_where_not
branch
from
95569d0
to
12a9664
Compare
|
I'll going to merge the deprecation in 6.0 to will fix |
| if not_behaves_as_nor?(opts) | ||
| ActiveSupport::Deprecation.warn(<<~MSG.squish) | ||
| NOT conditions will no longer behave as NOR in Rails 6.1. | ||
| To continue using NOR conditions, NOT each conditions manually |
There was a problem hiding this comment.
This message is confusing. How about?
To continue using NOR conditions, chain each `NOT` condition manually.
We probably should add a new method that do the NAND too. Maybe invert as suggested by @matthewd?
There was a problem hiding this comment.
aried3r
added a commit
to aried3r/acts_as_archival
that referenced
this pull request
Mar 27, 2020
.where.not() is being switched to NAND from NOR. https://blog.bigbinary.com/2019/07/31/rails-6-deprecates-where-not-working-as-nor-and-will-change-to-nand-in-rails-6-1.html rails/rails#36029
10 tasks
stejskalleos
added a commit
to stejskalleos/foreman_ansible
that referenced
this pull request
Apr 22, 2022
Changes: - loading of host extension helper - Rails 6 'where.not' use NAND instead of NOR [0] [0] rails/rails#36029
stejskalleos
added a commit
to stejskalleos/foreman
that referenced
this pull request
Apr 27, 2022
Changes overview: - Set default Rails version to 6.1 - Required dynfow >= 1.6.5 - Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml - ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter - model.errors.attribute_names instead of model.errors.keys - Fixed issue with iterating over the model.errors - use .add for adding error messages instead of << - 'where.not' use NAND instead of NOR [0] [0] rails/rails#36029
adamruzicka
pushed a commit
to theforeman/foreman_ansible
that referenced
this pull request
May 11, 2022
Changes: - loading of host extension helper - Rails 6 'where.not' use NAND instead of NOR [0] [0] rails/rails#36029
adamruzicka
pushed a commit
to theforeman/foreman
that referenced
this pull request
May 24, 2022
Changes overview: - Set default Rails version to 6.1 - Required dynfow >= 1.6.5 - Cleanup deprecation warnings in config/as_deprecation_whitelist.yaml - ActiveSupport::ParameterFilter instead of ActionDispatch::Http::ParameterFilter - model.errors.attribute_names instead of model.errors.keys - Fixed issue with iterating over the model.errors - use .add for adding error messages instead of << - 'where.not' use NAND instead of NOR [0] [0] rails/rails#36029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where.notwith polymorphic association is partly fixed incidentally at213796f (refer #33493, #26207, #17010, #16983, #14161), and I've added
test case e9ba12f to avoid lose that fix accidentally in the future.
In Rails 5.2,
where.not(polymorphic: object)works as expected asNAND, but
where.not(polymorphic_type: object.class.polymorphic_name, polymorphic_id: object.id)still unexpectedly works as NOR.To will make
where.notworking desiredly as NAND in Rails 6.1, thisdeprecates
where.notworking as NOR. If people want to continue NORconditions, we'd encourage to them to
where.noteach conditionsmanually.
In Rails 6.0:
In Rails 6.1:
Resolves #31209.