Fix sliced IN clauses to be grouped #36074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rails#35838. And also this refactors `in_clause_length` handling is entirely integrated in Arel visitor.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 26, 2020
`in_clause_length` was added at c5a284f to address to Oracle IN clause length limitation. Now `in_clause_length` is entirely integrated in Arel visitor since rails#35838 and rails#36074. Since Oracle visitors are the only code that rely on `in_clause_length`. so I'd like to remove that from Rails code base, like has removed Oracle visitors (rails#38946).
kamipo
added a commit
to kamipo/activerecord-sqlserver-adapter
that referenced
this pull request
Apr 27, 2020
Since rails/rails#36074, `in_clause_length` will no longer help the adapter to avoid complex query limitation, and will be removed from Rails code base (rails/rails#39057).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #35838.
And also this refactors
in_clause_lengthhandling is entirelyintegrated in Arel visitor.
cc @yahonda