Change the deprecation for Enumerating ActiveModel::Errors to Rails 6.1 instead of 6.0 #36087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Apr 25, 2019
| @@ -231,17 +231,17 @@ def each(&block) | |||
| else | |||
| ActiveSupport::Deprecation.warn(<<-MSG.squish) | |||
There was a problem hiding this comment.
Looks like this message expects new line as a structure, squish isn't matched in that case.
Can you change squish to squiggly heredoc?
Suggested change
| ActiveSupport::Deprecation.warn(<<-MSG.squish) | |
| ActiveSupport::Deprecation.warn(<<~MSG) |
….1 instead of 6.0
abhaynikam
force-pushed
the
32313-change-the-rails-version-in-deprecation-message
branch
from
c18bd21
to
e6daff1
Compare
|
Can you update this line too? rails/activemodel/lib/active_model/errors.rb Lines 616 to 618 in 5e24c33 |
…e, values, keys and to_xml
Edouard-chin
pushed a commit
to Edouard-chin/rails
that referenced
this pull request
Jul 8, 2019
….1 instead of 6.0 (rails#36087) * Change the deprecation for Enumerating ActiveModel::Errors to Rails 6.1 instead of 6.0 * Changed the deprecation message for ActiveModel::Errors methods: slice, values, keys and to_xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at PR #32313 I found the deprecation message was added for Rails 6.0 but this was merged as part of Rails 6.1. This caught my attention so raised PR immediately instead of waiting.
I do not have a lot of context about this change so let me know if this is incorrect.
cc/ @lulalala @rafaelfranca