Add 6.0 Release Notes for Action Pack #36107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcameron89
force-pushed
the
add_more_release_notes
branch
from
970d968
to
4c05491
Compare
prathamesh-sonpatki
suggested changes
Apr 26, 2019
guides/source/6_0_release_notes.md
Outdated
| * Allow the use of `parsed_body` in `ActionController::TestCase`. | ||
| ([Pull Request](https://github.com/rails/rails/pull/34717)) | ||
|
|
||
| * Raise an error on root route naming conflicts. |
There was a problem hiding this comment.
We can expand on this, perhaps something like ~
Raise an error when a root route exists and other is defined without name.
There was a problem hiding this comment.
How do you like Raise an ArgumentError when multiple root routes exists in the same context without as: naming specifications.?
I've gone through the CHANGELOG for Action Pack, pulled out anything that was backported, rephrased some of the descriptions and found their PR's/commits as links.
alexcameron89
force-pushed
the
add_more_release_notes
branch
from
4c05491
to
fdb44b4
Compare
|
Thank you @rafaelfranca and @prathamesh-sonpatki, I've made those changes. 馃槃 |
rafaelfranca
approved these changes
Apr 26, 2019
prathamesh-sonpatki
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've gone through the CHANGELOG for Action Pack, pulled out anything
that was backported, rephrased some of the descriptions and found their
PR's/commits as links.
If there is anything that you feel I should remove, please let me know. 馃槃