Fallback to spawn instead of fork in jruby #36111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: b342db6 introduced a `fork` fork when running the railties tests since this is not supported in jruby we fallback to using spawn. Fixes: rails#35900
itsWill
commented
Apr 26, 2019
|
Can you squash the commits? |
|
@itsWill This looks fantastic and the fork respondTo is definitely the best way. |
|
@guilleiguaran is it possible to merge this into 6.0-stable branch as well, please? I’m trying to report all possible issues with Rails 6.0 in TruffleRuby. |
guilleiguaran
pushed a commit
that referenced
this pull request
Apr 26, 2019
|
I've backported this to 6-0-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit: b342db6 introduced a
forkfork when running the railtiestests since this is not supported in jruby we fallback to using spawn.
Fixes: #35900