Add notification hooks for connection events #36113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`connect.action_cable` and `disconnect.action_cable` notifications are added. They can be used to instrument application-specific code performed during connect/disconnect.
|
Is there anything here which should be considered? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In comparison to channels, the application-specific code doesn't have any way to instrument it yet. At the moment, if we want to measure performance, instrument connection code with APM or gather any connect/disconnect statistics, it can only be done on the application code level or monkeypatching framework classes.
connect.action_cableanddisconnect.action_cablenotifications were added in order to address the issue.Event payload consists of:
connection_class– name of the connection class since we can support multiple since #34714request– the request that initiated the WebSocket connection. It provides access to the environment, cookies, etc.