Revert changes to monotonic times #36148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to monotonic times causes failures for applications where the subscribed block is expecting Time objects as described in this issue: rails#36145 The original PR (rails#35984) was concerned with errors on the cpu_time. Test was edited to reflect changes to initializer using 0 values instead of nil
|
I merged this so we can move forward with our upgrade, but let's make sure we follow through with the proposal in the issue as well. |
eileencodes
added a commit
that referenced
this pull request
May 1, 2019
…ations Revert changes to monotonic times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to monotonic times causes failures for applications
where the subscribed block is expecting Time objects as described
in this issue: #36145
The original PR (#35984) was
concerned with errors on the cpu_time. Test was edited to reflect
changes to initializer using 0 values instead of nil
cc/ @cpruitt @eileencodes @tenderlove