Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downloading section #36162

Merged
merged 2 commits into from Dec 17, 2019
Merged

Update downloading section #36162

merged 2 commits into from Dec 17, 2019

Conversation

thomasdarde
Copy link
Contributor

Added a precision on callbacks and file availability

Summary

Other Information

Added  a precision on callbacks and file availability
@rails-bot rails-bot bot added the docs label May 2, 2019
Copy link
Contributor Author

@thomasdarde thomasdarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the change, thank you Rafael

@rails-bot
Copy link

rails-bot bot commented Dec 17, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@rails-bot rails-bot bot added the stale label Dec 17, 2019
@@ -415,6 +415,8 @@ message.video.open do |file|
end
```

It's important to know that the file are not yet available in the `after_create` callback but in the `after_create_commit` only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's important to know that the file are not yet available in the `after_create` callback but in the `after_create_commit` only
It's important to know that the file are not yet available in the `after_create` callback but in the `after_create_commit` only.

@rails-bot rails-bot bot removed the stale label Dec 17, 2019
rafaelfranca added a commit that referenced this pull request Dec 17, 2019
@rafaelfranca rafaelfranca merged commit 5d0ae7e into rails:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants