Fix folders update watcher with no folders to watch #36163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
approved these changes
May 22, 2019
rafaelfranca
requested changes
May 22, 2019
activesupport/lib/active_support/evented_file_update_checker.rb
Outdated
Show resolved
Hide resolved
activesupport/lib/active_support/evented_file_update_checker.rb
Outdated
Show resolved
Hide resolved
|
@rafaelfranca @jhawthorn Can you have a second look to this PR ? |
kaspth
reviewed
Jul 26, 2019
activesupport/lib/active_support/evented_file_update_checker.rb
Outdated
Show resolved
Hide resolved
|
@rafaelfranca ready for a new review 馃槃 |
|
Great job, @spuyet 鉂わ笍馃挭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes the
ActiveSupport::EventedFileUpdateCheckerbehavior trying to use theListenconstant even when the gem is not loaded because there is no directory to watch. I've described the issue here.I've also prefixed the call to
Listenwith the scope resolution operator as this is a top level constant and it's not defined inActiveSupport::EventedFileUpdateChecker.Let me know if you need more informations 馃槃