Use a single term instead of all terms used to describe path and URL helpers together #36254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharang-d
force-pushed
the
remove-named-helpers
branch
from
03c8e0d
to
e9b2e64
Compare
sharang-d
changed the title
sharang-d
force-pushed
the
remove-named-helpers
branch
from
e9b2e64
to
797e740
Compare
rafaelfranca
requested changes
Jul 26, 2019
|
Thanks, I'll use that term. |
sharang-d
force-pushed
the
remove-named-helpers
branch
3 times, most recently
from
967b2e7
to
93bc6d2
Compare
|
I've pushed the changes. |
rafaelfranca
requested changes
Jul 26, 2019
guides/source/routing.md
Outdated
| @@ -210,7 +210,7 @@ end | |||
|
|
|||
| This will create a number of routes for each of the `articles` and `comments` controller. For `Admin::ArticlesController`, Rails will create: | |||
|
|
|||
| | HTTP Verb | Path | Controller#Action | Named Helper | | |||
| | HTTP Verb | Path | Controller#Action | Route Helper | | |||
There was a problem hiding this comment.
should not it be Named Route Helper?
sharang-d
force-pushed
the
remove-named-helpers
branch
from
93bc6d2
to
208a861
Compare
sharang-d
force-pushed
the
remove-named-helpers
branch
from
208a861
to
18504eb
Compare
rafaelfranca
added a commit
that referenced
this pull request
Jul 26, 2019
Use a single term instead of all terms used to describe path and URL helpers together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36233.
I agree with the sentiment behind the original issue: We need a single term to say "URL and Route helpers" and this is my attempt at getting there.
I'm open to suggestions for a better term if anyone has any.