Wrap ActionView cache expiry in a mutex #36323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhawthorn
changed the title
rafaelfranca
added a commit
that referenced
this pull request
May 23, 2019
Wrap ActionView cache expiry in a mutex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #36094
I was able to confirm locally that multiple requests can enter the
clear_cache_if_necessarymethod (I wasn't able to get the same error, but it makes sense that it can happen). I guess this is because we're running inExecutor#beforerather than as part ofReloader(maybe this is another hint to me that it should be moved there 馃し鈥嶁檪).Because of this we should wrap
clear_cache_if_necessarywith a Mutex (this is just the check and clear before a request). This only runs in dev mode, and in my local testing there wasn't a significant performance change to adding the mutex.cc @kaspth @composerinteralia