Allow symbol (i.e. quoted identifier) as safe SQL string #36350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pluck(:id)
/order(:id)
are very common use case, and passed symbol(i.e. quoted identifier) is obviously safe argument, but
:id.to_s.split(/\s*,\s*/).all? { |part| permit.match?(part) }
isuseless and a bit expensive operation for each such safe symbols (will
make extra 2 mutable strings, 1 array, 1 proc).
This avoids the expensive operation to such safe symbols, it makes
pluck(:id)
/order(:id)
itself about 9% faster.https://gist.github.com/kamipo/11d428b57f3629a72ae89c6f21721326
Before (93e6407):
After (this change):