Don't break configurations.each, .first before the deprecation period #36372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change broke the tests. Can you take a look? |
|
I saw that and will try to take a closer look tomorrow. I had some trouble
running the tests in question locally this afternoon.
…On Thu, Jul 25, 2019 at 9:09 PM Rafael França ***@***.***> wrote:
This change broke the tests. Can you take a look?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#36372?email_source=notifications&email_token=AE5HBJNVNZHR34KUJ72HTELQBJ2GDA5CNFSM4HR5SXVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23N5AI#issuecomment-515300993>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE5HBJKTTTCQX3EFSYPXAP3QBJ2GDANCNFSM4HR5SXVA>
.
|
rafaelfranca
added a commit
that referenced
this pull request
Jul 26, 2019
Don't break configurations.each, .first before the deprecation period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was working on a library (switchman) that uses configuration.each and realized that it was broken (despite being listed as just deprecated) relative to Rails 5. I whipped up this change to fix it but I'm not sure if this is desired at this point in the release cycle. This is a first draft meant mostly as a chance for the maintainers to say "we're too frozen for this right now"; let me know if that isn't the case and you would like me to add tests or change anything.