Address occasional test_pluck_columns_with_same_name failure #36378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Jun 2, 2019
| @@ -838,7 +838,7 @@ def test_pluck_replaces_select_clause | |||
| def test_pluck_columns_with_same_name | |||
| expected = [["The First Topic", "The Second Topic of the day"], ["The Third Topic of the day", "The Fourth Topic of the day"]] | |||
| actual = Topic.joins(:replies) | |||
There was a problem hiding this comment.
How about adding order(:id)?
It is coincidental that id:1's title and id:3's title are alphabetical order.
Suggested change
| actual = Topic.joins(:replies) | |
| actual = Topic.joins(:replies).order(:id) |
There was a problem hiding this comment.
Thanks for the review. Updated.
I should have referred the test test_pluck_replaces_select_clause above which also specifies order using order(:id).
…stic sort order ```ruby $ bundle exec rake test_postgresql ... snip ... Failure: CalculationsTest#test_pluck_columns_with_same_name [/home/yahonda/git/rails/activerecord/test/cases/calculations_test.rb:842]: --- expected +++ actual @@ -1 +1 @@ -[["The First Topic", "The Second Topic of the day"], ["The Third Topic of the day", "The Fourth Topic of the day"]] +[["The Third Topic of the day", "The Fourth Topic of the day"], ["The First Topic", "The Second Topic of the day"]] ```
yahonda
force-pushed
the
test_pluck_columns_with_same_name
branch
from
afc4262
to
86384ea
Compare
kamipo
added a commit
that referenced
this pull request
Nov 19, 2019
Address occasional test_pluck_columns_with_same_name failure
JesseChavez
pushed a commit
to JesseChavez/rails
that referenced
this pull request
Dec 19, 2019
…ame_name Address occasional test_pluck_columns_with_same_name failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses
test_pluck_columns_with_same_namefailure due to non deterministic sort order. This failure is occasional, does not always reproduce.