Delete method definition in rails that is compatible with ruby defini… #36497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamipo
reviewed
Jun 16, 2019
|
@kamipo
If this is ok I will rebase the commit. |
kamipo
approved these changes
Jun 16, 2019
kamipo
reviewed
Jun 16, 2019
kamipo
reviewed
Jun 16, 2019
soartec-lab
force-pushed
the
move_date_and_time_method_to_time
branch
from
14d40da
to
2e5094d
Compare
…th ruby definition Tests are also only on the `Time` class Update doc forgetting to erase when moved Update guide `Date` class to `Time` class and defined file Update guide correction omission
soartec-lab
force-pushed
the
move_date_and_time_method_to_time
branch
from
2e5094d
to
bfecb7d
Compare
|
I corresponded to all the issues pointed out and squash commits into one. |
|
Thanks! By the way (it's off-topic), AFAICS you are Japanese (same with me), so I'd recommend double-checking with Japanese-English translation, it would help you hopefully.
|
|
Thank you for merging ! I'm still studying OSS development and English and I'm always bothering you. sorry. |
kamipo
added a commit
that referenced
this pull request
Jun 17, 2019
…to_time Delete method definition in rails that is compatible with ruby defini…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following methods are already defined in ruby's
Dateclass and are compatible, so there is no need to extendDateclass with rails.It also proves that the test passes.
I moved it because I only needed the
Timeclass.