Add the ability to set the CSP nonce only to the specified directives #36534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I changed to set CSP nonce to `style-src` directive in rails#32932. But this causes an issue when `unsafe-inline` is specified to `style-src` (If a nonce is present, a nonce takes precedence over `unsafe-inline`). So, I fixed to nonce directives configurable. By configure this, users can make CSP as before. Fixes rails#35137.
pixeltrix
approved these changes
Jul 2, 2019
y-yagi
added a commit
that referenced
this pull request
Jul 2, 2019
Add the ability to set the CSP nonce only to the specified directives
bendilley
reviewed
Feb 21, 2024
| def nonce_directive?(directive) | ||
| NONCE_DIRECTIVES.include?(directive) | ||
| def nonce_directive?(directive, nonce_directives) | ||
| nonce_directives.include?(directive) |
There was a problem hiding this comment.
To account for this being overridden in the controller with 'unsafe-inline' :
nonce_directives.include?(directive) &&
!directives[directive].include?(MAPPINGS[:unsafe_inline])I have a situation where I'd like to default to nonce-generation, but go unsafe-inline for some requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed to set CSP nonce to
style-srcdirective in #32932.But this causes an issue when
unsafe-inlineis specified tostyle-src(If a nonce is present, a nonce takes precedence overunsafe-inline).So, I fixed to nonce directives configurable. By configure this, users can make CSP as before.
Fixes #35137.