Fix Browser#preload for older Selenium #36602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of selenium had driver_path on ::Selenium::WebDriver::Chrome directly, not on Service. This avoids errors on those old versions and will preload properly if webdrivers is installed.
Since rails#36424, we need an newer version in order to pass.
eileencodes
approved these changes
Jul 5, 2019
jhawthorn
added a commit
to jhawthorn/rails
that referenced
this pull request
Jul 6, 2019
Fix Browser#preload for older Selenium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #36592
Older versions of selenium had
driver_pathon::Selenium::WebDriver::Chromedirectly, not on...::Service. This avoids errors on those old versions and will preload properly if webdrivers is installed.I learned this because I broke tests on 6-0-stable when backporting the initial commit (oops! 馃槼). We'll probably want to also bump the selenium version on 6-0-stable to make the test added in #36592 pass.