Move the ActiveModel:Errors#full_message method to the Error class:
#36639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
force-pushed
the
ec-am-errors-fullmessages
branch
3 times, most recently
from
328cdf1
to
e86149e
Compare
rafaelfranca
requested changes
Jul 15, 2019
| default: defaults, | ||
| attribute: attr_name, | ||
| message: message) | ||
| Error.full_message(attribute, message, @base) |
There was a problem hiding this comment.
We should pass @base.class downstream because we only use that.
Edouard-chin
force-pushed
the
ec-am-errors-fullmessages
branch
from
e86149e
to
6383340
Compare
Edouard-chin
force-pushed
the
ec-am-errors-fullmessages
branch
2 times, most recently
from
475c9f0
to
dd97dce
Compare
- One regression introduced by the "AM errors as object" features is about the `full_messages` method. It's currently impossible to call that method if the `base` object passed in the constructor of `AM::Errors` doesn't respond to the `errors` method. That's because `full_messages` now makes a weird back and forth trip `AM::Errors#full_messages` -> `AM::Error#full_message` -> `AM::Errors#full_message` Since `full_message` (singular) isn't needed by AM::Errors, I moved it to the `AM::Error` (singular) class. This way we don't need to grab the `AM::Errors` object from the base.
- Since `ActiveModel::Error` can now be inherited by `ActiveModel::NestedError`, when the latter generates a `full_message`, the `i18n_customize_full_message` accessor set in the parent class is not set. This commit fixes that by using a `class_attribute` instead.
Edouard-chin
force-pushed
the
ec-am-errors-fullmessages
branch
from
dd97dce
to
d204a09
Compare
|
Should be good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
ActiveModel:Errors#full_messagemethod to theErrorclass:One regression introduced by the "AM errors as object" features is
about the
full_messagesmethod.It's currently impossible to call that method if the
baseobjectpassed in the constructor of
AM::Errorsdoesn't respond to theerrorsmethod.That's because
full_messagesnow makes a weird back and forth tripAM::Errors#full_messages->AM::Error#full_message->AM::Errors#full_messageSince
full_message(singular) isn't needed by AM::Errors, I movedit to the
AM::Error(singular) class. This way we don't need tograb the
AM::Errorsobject from the base.cc/ @casperisfine @rafaelfranca