Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs inside disabled fieldset are not submited on remote: true forms #36764

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Inputs inside disabled fieldset are not submited on remote: true forms #36764

merged 2 commits into from
Jul 26, 2019

Conversation

willianveiga
Copy link
Contributor

Fixes #36728.

@rafaelfranca
Copy link
Member

Thank you for the pull request. Can you write a test for this change?

@rafaelfranca rafaelfranca merged commit 1760fe9 into rails:master Jul 26, 2019
rafaelfranca added a commit that referenced this pull request Jul 26, 2019
@rafaelfranca
Merge pull request #36764 from willianveiga/feature/inputs-inside-dis…
91d5e4f 
…abled-fieldset-are-not-submited-on-remote-true-forms

Inputs inside disabled fieldset are not submited on remote: true forms
@fiznool
Copy link

fiznool commented Aug 14, 2019

Just to note that this uses Element.closest which isn't supported on IE without a polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
actionview rails-ujs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inputs inside disabled fieldset are submited on remote: true forms
3 participants
@willianveiga @rafaelfranca @fiznool