Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #36812

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Update README.md #36812

merged 1 commit into from
Jul 30, 2019

Conversation

crifat
Copy link
Contributor

@crifat crifat commented Jul 30, 2019

A very minor change of comma usage.

A very minor change of comma usage.
@kamipo
Copy link
Member

kamipo commented Jul 30, 2019

Thank you but we don't accept cosmetic changes.
https://guides.rubyonrails.org/contributing_to_ruby_on_rails.html#write-your-code

@kamipo kamipo closed this Jul 30, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

@dhh

Also this :D.

How <redacted> is this project managed.

@sikachu
Copy link
Member

sikachu commented Jul 30, 2019

@kamipo this looks like a documentation change to fix grammar and not cosmetic change, so I'm going to open and merge this. Sorry for reverting your action.

@sikachu sikachu reopened this Jul 30, 2019
@sikachu sikachu merged commit bd822a4 into rails:master Jul 30, 2019
@dhh
Copy link
Member

dhh commented Jul 30, 2019

@LemonAndroid You’re in violation of the Code of Conduct for Rails. This is your final warning to follow the CoC and behave respectfully towards everyone working on this project. If you fail to do so again, you will be banned from participating on this repository.

@dhh
Copy link
Member

dhh commented Jul 30, 2019

@LemonAndroid I see that other community members have already given you a 3-day timeout. Good. Take the break to read the CoC and return with an appropriate style of engagement if you wish to participate in Rails development. But the warning otherwise stands. The next ban is permanent.

@crifat crifat deleted the readme-comma-usage branch May 6, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants