Add ability to unset preventing writes #36843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if an app attempts to do a write inside a read request it will be impossilbe to switch back to writing to the primary. This PR adds an argument to the `while_preventing_writes` so that we can make sure to turn it off if we're doing a write on a primary. Fixes rails#36830 Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
eileencodes
added a commit
that referenced
this pull request
Aug 2, 2019
…nting-writes Add ability to unset preventing writes
|
Backported to 6-0-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an app attempts to do a write inside a read request it will be
impossible to switch back to writing to the primary. This PR adds an
argument to the
while_preventing_writesso that we can make sure toturn it off if we're doing a write on a primary.
Fixes #36830
Co-authored-by: John Crepezzi john.crepezzi@gmail.com
cc/ @tenderlove @jhawthorn @rafaelfranca @matthewd