Allow easily testing multi-part emails in ActionMailbox #36856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you wanted to test a multi-part email -- for example, an email that has both a plaintext part and an HTML part -- there wasn't a way to easily build one without a pre-made fixture. By allowing you to pass a block to the `create_inbound_email_from_mail` method, we unlock the power of `Mail.new` to easily create a variety of emails, from multi-part emails, to emails with attachments, and beyond.
Like with its `create_` counterpart, it is useful to be able to immediately process a flexibly-created email with multiple parts, attachments, and the like. Allowing the use of the block constructor makes this method more flexible and easier to use.
| \r | ||
| <h1>Hello, world</h1> | ||
| HTML | ||
| end |
There was a problem hiding this comment.
This test case is for ActionMailbox::InboundEmail. How about adding ActionMailbox::TestHelperTest in test/unit/test_helper_test.rb?
There was a problem hiding this comment.
Good point! I put it here since there wasn't an explicit test for TestHelper, but that makes a lot of sense to me.
abhaynikam
reviewed
Aug 7, 2019
| test "multi-part mail can be built in tests using a block" do | ||
| inbound_email = create_inbound_email_from_mail do | ||
| to "test@example.com" | ||
| from "hello@example.com" |
There was a problem hiding this comment.
This test is missing the assertion for subject. I think we should add it.
abhaynikam
reviewed
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you wanted to test a multi-part email -- for example, an email that
has both a plaintext part and an HTML part -- there wasn't a way to
easily build one without a pre-made fixture. By allowing you to pass a
block to the
create_inbound_email_from_mailmethod, we unlock thepower of
Mail.newto easily create a variety of emails, frommulti-part emails, to emails with attachments, and beyond.
Other Information
The
rdoc-reftoInboundEmailwasn't linking up when I was testing it.I was running
bundle exec rake rdocto generate the documentation,which I think is correct, but noticed that it was dropping the link.