Add at option to perform_enqueued_jobs test helper #36864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `perform_enqueued_jobs` helpers will also immediately perform jobs that are scheduled via `set(wait:)` to run in the future. This commit adds a new argument to `perform_enqueued_jobs` to make it only run jobs scheduled at or before the passed in `Time`. This allows testing the side effects of immediate job execution separate of jobs delayed in the future.
seejohnrun
force-pushed
the
activejob-test-helper-set-wait
branch
from
549c21c
to
647317d
Compare
| @@ -117,7 +117,7 @@ def queue_adapter_for_test | |||
| # HelloJob.perform_later('elfassy') | |||
| # end | |||
| # end | |||
| def assert_enqueued_jobs(number, only: nil, except: nil, queue: nil) | |||
| def assert_enqueued_jobs(number, only: nil, except: nil, queue: nil, at: at) | |||
There was a problem hiding this comment.
This causes a warning:
activejob/lib/active_job/test_helper.rb:120: warning: circular argument reference - at
Why is this unused argument needed?
There was a problem hiding this comment.
Thanks! Addressed in #36881
|
We should add a changelog entry in |
seejohnrun
added a commit
to seejohnrun/rails
that referenced
this pull request
Aug 7, 2019
In rails#36864 we made a change to an ActiveJob test helper to add a new parameter for testing jobs delayed into the future. This commit adds a CHANGELOG entry for that change as well as fixing a circular argument error.
|
@bogdanvlviv added in #36881! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the
perform_enqueued_jobshelper will also immediatelyperform jobs that are scheduled via
set(wait:)to run in the future.This PR adds a new argument to
perform_enqueued_jobsto make itonly run jobs scheduled at or before the passed in
Time. This allowstesting the side effects of immediate job execution separate of jobs
delayed in the future.