PostgreSQL GIN and GiST index support #3699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GIN support. added tests
| # CREATE INDEX index_developers_on_name ON developers USING gist(name) | ||
| # | ||
| def add_index(table_name, column_name, options = {}) | ||
| if !!options.delete(:gin) |
There was a problem hiding this comment.
Can you remove the !!, and don't mutate the options hash that's passed in?
There was a problem hiding this comment.
sure thing, adding the fix...
|
We need to make sure that the |
|
nuts... i thought adding the commit would update this pull request... looks like it just opened a new one >< noob |
|
le sigh I guess this should close and be pointed to this pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added add_index override in postgresql_adapter to allow for GiST and GIN support.
Added tests.