Logging at info level should be reserved for top-level concerns #37040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeclaghorn
force-pushed
the
reduce-info-level-logging
branch
from
d055f2f
to
cd83bcf
Compare
Information about partials and cable connection notices are too low level.
georgeclaghorn
force-pushed
the
reduce-info-level-logging
branch
from
cd83bcf
to
6315a11
Compare
georgeclaghorn
approved these changes
Aug 26, 2019
rafaelfranca
approved these changes
Sep 4, 2019
eileencodes
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to reduce logging volume at Basecamp in non-debug situations. The log level of INFO should be reserved for a top-level summary as it pertains to the request. The Who, What, When. So attempt to demote all extraneous logging to the DEBUG level.