Don't hardcode locale for to_sentence #37047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure the locale is needed at all. This isn't an error that we show to users on the frontend and looking through the rest of ActiveRecord we don't directly pass locale into those either. I tracked this change down to 6de8356 and it's clear from other uses of What do you think? |
|
@eileencodes makes sense to me, I'll make that change! |
dvandersluis
force-pushed
the
37044-fix-exception-message
branch
2 times, most recently
from
9951701
to
63b3617
Compare
|
FWIW it looks like is the only other place that is using a hardcoded I18n locale withto_sentence currently.
|
dvandersluis
changed the title
|
@eileencodes should I change ☝️ that one too? |
|
Yup, let's update that one too. |
For example, HasManyThroughSourceAssociationNotFoundError uses to_sentence to create its message, but was hardcoded to use the `en` locale. In cases where this locale did not exist, this caused the exception to be suppressed in favour of an I18n::InvalidLocale exception. This change removes the hardcoded locale, which allows I18n to use its default locale.
dvandersluis
force-pushed
the
37044-fix-exception-message
branch
from
63b3617
to
b99c21a
Compare
|
@eileencodes done! |
eileencodes
added a commit
that referenced
this pull request
Aug 28, 2019
Don't hardcode locale for to_sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a
HasManyThroughSourceAssociationNotFoundErrorexception is raised, and there is noenlocale, the user receives aI18n::InvalidLocale: :en is not a valid localeexception instead which suppresses the actual error.This change just checks for an
enlocale being available and falls back toI18n.default_localeif it's not.Fixes #37044.