Add doc about I18n support for :placeholder option [ci skip] #37054
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
reviewed
Aug 27, 2019
| @@ -165,7 +165,7 @@ def select_tag(name, option_tags = nil, options = {}) | |||
| # * <tt>:disabled</tt> - If set to true, the user will not be able to use this input. | |||
| # * <tt>:size</tt> - The number of visible characters that will fit in the input. | |||
| # * <tt>:maxlength</tt> - The maximum number of characters that the browser will allow the user to enter. | |||
| # * <tt>:placeholder</tt> - The text contained in the field by default which is removed when the field receives focus. | |||
| # * <tt>:placeholder</tt> - The text contained in the field by default which is removed when the field receives focus. If set to true, use a translation is found in the current I18n locale (through helpers.placeholders.<modelname>.<attribute>). | |||
There was a problem hiding this comment.
Can you fix this to wrap at 80 characters? Don't update the rest of the file, just the new docs you added. Thanks!
There was a problem hiding this comment.
Thank you for your review. I added a line break and did fource-push.
The :placeholder option accepts true, so it should be mentioned in the documentation. Ref: rails#16438
sinsoku
force-pushed
the
patch/add_doc_for_placeholder_option
branch
from
b7d6a84
to
7b157f1
Compare
eileencodes
added a commit
that referenced
this pull request
Aug 27, 2019
…option Add doc about I18n support for :placeholder option [ci skip]
eileencodes
added a commit
that referenced
this pull request
Aug 27, 2019
…option Add doc about I18n support for :placeholder option [ci skip]
|
Backported to 6-0-stable and 5-2-stable |
sharang-d
reviewed
Aug 27, 2019
| @@ -166,6 +166,8 @@ def select_tag(name, option_tags = nil, options = {}) | |||
| # * <tt>:size</tt> - The number of visible characters that will fit in the input. | |||
| # * <tt>:maxlength</tt> - The maximum number of characters that the browser will allow the user to enter. | |||
| # * <tt>:placeholder</tt> - The text contained in the field by default which is removed when the field receives focus. | |||
| # If set to true, use a translation is found in the current I18n locale | |||
There was a problem hiding this comment.
use a translation is found in
->
use the translation found in
JesseChavez
pushed a commit
to JesseChavez/rails
that referenced
this pull request
Dec 19, 2019
…lder_option Add doc about I18n support for :placeholder option [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :placeholder option accepts true, so it should be mentioned in the documentation.
Ref: #16438