Extend test_can_write_while_reading_from_replicas_if_explicit
#37091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that explicit method call `connected_to` with `prevent_writes: false` turns off 'preventing writes' in the passed block. - Ensure that after explicit call method call `connected_to` with `prevent_writes: false` 'preventing writes' is retained Related to rails#37065
eileencodes
added a commit
that referenced
this pull request
Aug 30, 2019
Extend `test_can_write_while_reading_from_replicas_if_explicit`
|
Backported to 6-0-stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected_towithprevent_writes: falseturns off 'preventing writes' in the passed block.
connected_towithprevent_writes: false'preventing writes' is retained
Related to #37065
@eileencodes Please let me know whether you think those asserts makes sense to add.