activerecord: Allow comment prefix in queries when preventing writes #37184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rafaelfranca
Problem
We use marginalia attach comments to queries to help provide context for queries in the slow query log. We also use
Marginalia::Comment.prepend_comment = true
to prepend the comment so it isn't lost from truncation. However, this resulted in theActiveRecord::ConnectionAdapters::MySQL::DatabaseStatements::READ_QUERY
to no longer match any queries, which would prevent any queries from being performed on a database connection configured withreplica: true
due to it trying to prevent write queries.Solution
Update the regex to ignore
/*
...*/
comments at the start of the query string.