stylesheet_tag default's media is "screen" #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the default generators.
|
This looks good to me. @josevalim, thoughts? |
|
Yes, please do merge. |
wycats
added a commit
that referenced
this pull request
Nov 22, 2011
stylesheet_tag default's media is "screen"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect that any website I visit will, at worst, print exactly the way it looks on screen.
Rails doesn't default to that since
stylesheet_tag's media default is set to "screen", andstylesheet_tagwithout amediaoption.I would favor removing the default media type altogether, but I suspect that for compatibility reasons it will be judged that this can't be done.
So my patch changes (2) above by specifying
:media => "all"in the default generated layout, and improves the documentation.Thanks.