ActiveRecord valid? should includes ActiveModel validation for integer type column

[baoqchau]

Steps to reproduce

https://gist.github.com/baoqchau/1ee3f2a1d11b4a006f1f2ab70451be62

Expected behavior

post.valid? should return false.

Actual behavior

post.valid? return true and then when you save it (post.save!) it will return the ActiveModel error. is out of range for ActiveModel::Type::Integer with limit 4 bytes,

System configuration

Rails version:
6.0.0
Ruby version:
2.6.3

[joshmn]

Your example app doesn't have any validations in it, is this expected?

If you need to validate this, though, validates :number_of_comment, inclusion: (-2147483648..2147483648)

[baoqchau]

Yeah I agree that I can add that validation, but should we have this validation shows when you check valid? or when you initialize it? If not, I think we should have a way to add this as a default validation for integer type field in ActiveRecord.

[allcentury]

This is a problem of database constraints vs app validations, take a read through https://thoughtbot.com/blog/validation-database-constraint-or-both. It is a tough problem but I'm not sure if rails has a precedent for this.

[wjessop]

Looks to be the same issue as #37283

[kamipo]

This is not an issue but like a proposal.
Since we reserve the issues tracker for issues only, use the Rails Core mailing list for feature requests.