fix(fork-tracker): Only patch fork if it's supported #37385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are currently wrapped with `if Process.respond_to?(:fork)` but they're still executed on JRuby. The problem is that ForkTracker unconditionally patches `#fork` so `Process` does indeed `respond_to? :fork`. Fix it by installing the patch conditionally with the same check.
kaspth
reviewed
Oct 6, 2019
| ::Kernel.prepend(CoreExtPrivate) | ||
| ::Kernel.singleton_class.prepend(CoreExt) | ||
| ::Process.singleton_class.prepend(CoreExt) | ||
| if Process.respond_to?(:fork) |
There was a problem hiding this comment.
So the take away here is that if the process doesn't respond to fork then there's no need for the checker? Then how do we ensure we claim/reap the connections? cc @casperisfine
There was a problem hiding this comment.
Yup. When there's no fork available, there's no need to check and no need to claim/reap connections. E.g. on JRuby fork will always throw a "not implemented", so we're never in a situation that requires cleaning up connections
|
Thanks! |
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some tests are currently wrapped with
if Process.respond_to?(:fork)but they're still executed on JRuby. The problem is that ForkTracker
unconditionally patches
#forksoProcessdoes indeedrespond_to? :fork.Fix it by installing the patch conditionally with the same check.