raise an error if the old router draw method is used #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,6 +240,11 @@ module ActionDispatch | |||
| end | |||
|
|
|||
| def eval_block(block) | |||
| if block.arity == 1 | |||
| raise "You are using the old router DSL which has been removed in Rails 3.2. " << | |||
There was a problem hiding this comment.
ahhhhhhh bugger :)
one sec
…ssage advising them to either upgrade their routes or add rails_legacy_mapper to their Gemfile
|
updated :) |
| if block.arity == 1 | ||
| raise "You are using the old router DSL which has been removed in Rails 3.1. " << | ||
| "Please check how to update your routes file at: http://www.engineyard.com/blog/2010/the-lowdown-on-routes-in-rails-3/ " << | ||
| "or add the rails_legacy_mapper gem to your Gemfile" |
There was a problem hiding this comment.
Should we also add the github url of the gem as part of the message?
There was a problem hiding this comment.
Nah, it is fine without the github url. If someone really needs it, they can find it. :)
josevalim
added a commit
that referenced
this pull request
May 3, 2011
raise an error if the old router draw method is used
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
Follow up #370 for Oracle, to fix undefined method `expr' for 10:Fixnum bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
This commit raises an error if the old router draw method is used, along with a message advising them to either upgrade their routes or add rails_legacy_mapper to their Gemfile.
Let me know if the error type needs changing.
Thanks,
Josh