Fix lookup on HashWithIndifferentAccess for array values. #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 /cc @fxn |
| @@ -153,7 +153,8 @@ def convert_value(value) | |||
| if value.is_a? Hash | |||
| value.nested_under_indifferent_access | |||
| elsif value.is_a?(Array) | |||
| value.dup.replace(value.map { |e| convert_value(e) }) | |||
| value = value.dup if value.frozen? | |||
| value.replace(value.map { |e| convert_value(e) }) | |||
There was a problem hiding this comment.
I think you could just use value.map! instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HashWithIndifferentAccess has some odd behaviour that differs from Hash.
The problem:
Accessing a HashWithIndifferentAccess does not return the the same object that is stored in the hash (i.e. equal?) causing unexpected results:
The cause:
When a block is provided to generate default values the generated values are duped if they are arrays. The duped value is stored in the hash but the original value is returned when the hash is accessed.
My fix:
The duping is there for allowing frozen arrays containing hashes to be modified. My fix restricts the duping to this case. Note that if default function generates a frozen array an error will be raised on assignment before and after my patch.