Add method ActionCable::Channel#stream_or_reject_for to stream if record is present, otherwise reject the connection #38375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atul9
force-pushed
the
actioncable-stream-or-reject-for
branch
from
034430f
to
3547486
Compare
…ord is present, otherwise reject the connection
Atul9
force-pushed
the
actioncable-stream-or-reject-for
branch
from
3547486
to
5970429
Compare
Atul9
changed the title
bekicot
reviewed
Feb 28, 2020
Comment on lines
+127
to
+130
| # Calls stream_for if record is present, otherwise calls reject. | ||
| # This method is intended to be called when you're looking | ||
| # for a record based on a parameter, if its found it will start | ||
| # streaming. If the record is nil then it will reject the connection. |
There was a problem hiding this comment.
I think the code is already tell by itself what it does. The comment is no longer needed.
There was a problem hiding this comment.
I am ok to remove it when I get another comment from someone from core/committer team(who has access to merge this PR)
|
Hi @dhh can you please help to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #38371
As mentioned on issue #38371 ActionCable::Channel#stream_or_reject_for can be use to stream if the record is present otherwise reject the connection.