Update code snippets to suggest the use of strong parameters #38595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples for flash and session had code that would generally raise ForbiddenAttributesErrors. Tweak the examples to avoid this potentially misleading example. [ci skip]
|
Oops, I added Perhaps it has to be in the first line of the commit msg? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Examples for
flashandsessionhad code that would might end up raisingForbiddenAttributesErrors. Tweak the code to suggest the use of strong parameters.Other Information
I'm not sure what would be more helpful, the examples as-is are a little bit more direct and simple. But I did do a double-take when I saw them, which to me seemed like a good reason to make the change.
I could see someone copy-pasting this and being confused at the error that's raised. But now the examples are missing definitions for the
client_/comment_paramsmethods, so… I'm not sure what's better. 🤷♂