Better use #remove_possible_method here #388
Conversation
|
|
||
| class DateTime | ||
| # Ruby 1.9 has DateTime#to_time which internally relies on Time. We define our own #to_time which allows | ||
| # DateTimes outside the range of what can be created with Time. | ||
| remove_method :to_time if instance_methods.include?(:to_time) | ||
| remove_possible_method :to_time |
There was a problem hiding this comment.
If instance_methods doesn't have the to_time method, will the remove_method throw a NameError like the other cases?
There was a problem hiding this comment.
@vijaydev I don't follow the question exactly. Although this case is indeed different from the other ones because it will never be true for Ruby 1.8 as instance_methods return strings.
There was a problem hiding this comment.
Ok. The question was: When using the remove_possible_method, if the method doesn't exist, remove_method throws a NameError which is quietly ignored. Is that equivalent to checking for the method being part of the instance_methods and then calling remove_method ?
There was a problem hiding this comment.
Yes. But again, in this particular case, it is only removing the method on 1.9. So remove_possible_method should not be used here.
|
Removed the use of #remove_possible_method on DateTime::Conversions |
Better use #remove_possible_method here
Use #remove_possible_method in favor of #remove_method if method_defined?