Align Range#cover? extension behavior with plain Ruby behavior for "backwards" ranges
#38837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugeneius
reviewed
Mar 28, 2020
activesupport/lib/active_support/core_ext/range/compare_range.rb
Outdated
Show resolved
Hide resolved
|
@eugeneius thanks for the feedback. PR updated with revisions. |
eugeneius
reviewed
Mar 29, 2020
activesupport/lib/active_support/core_ext/range/compare_range.rb
Outdated
Show resolved
Hide resolved
eugeneius
reviewed
Mar 29, 2020
activesupport/lib/active_support/core_ext/range/compare_range.rb
Outdated
Show resolved
Hide resolved
|
This looks good, could you squash down to a single commit? |
…rds ranges. `(1..10).cover?(5..3)` now returns `false`, as it does in plain Ruby. Previously this returned `true`. Also update `#include?` and `#===` behavior to match.
|
@eugeneius done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously:
In
irb:In rails (HEAD) console
Updated the
Range#cover?core extension so that(1..10).cover?(5..3)now returnsfalse, as it does in plain Ruby.Also updated
#include?and#===behavior to match, though in this case there is no plain-Ruby equivalent.