Annotating haml and slim file

[kielkowiczk]

Hi,

Not sure why there is no way to annotate haml and slim file?
These template engines getting more and more popular, so why not allow to annotate them (with TODO, etc)?
Here is my proposal (code and tests) allowing annotation of these files.

Thanks for Your time:)

[josevalim]

Yes, that would be nice but we should instead provide a mechanism for extension of the code annotator instead of simply hardcoding the logic. :(

[kielkowiczk]

There are not that many engines, and they don't change that often, and it's not like new engines are emerging every week. Making mechanism for extension would nice (and challenging) but sound like over shoot (taking under consideration point listed above).

[josevalim]

This argument is moot because it is like saying Rails can hardcode all the code to test-unit and rspec, without providing an API, because that's basically what people use it anyway.

[kielkowiczk]

I see Your point, and You are probably right. Agree Rails should go in the direction of becoming more transparent and less hardcoded.

These commit ought to reflect change in Rails ecosystem, not revolutionizing Rails annotating system, just keeping it up to date:)

[josevalim]

Ok. I will merge it but basically because I liked the test coverage. ;) Could you please also rename the test file to railties/test/application/rake/notes_test.rb? Also, if you want to send another pull request extracting these https://github.com/kielkowicz/rails/blob/8f61df0bcd0e84f26c6c41b98eeb2f7bb8d5ca4b/railties/test/application/rake_test.rb#L111-177 to a new file called railties/test/application/rake/migration_test.rb you will gain extra <3 .

[kielkowiczk]

Done:)

[kielkowiczk]

@sobrinho, It's exactly what @josevalim (btw, thanks!) suggested, making some sort of mechanism for extensions, so it would be "easier" (in the meaning not hardcoded in Rails) for other template engines to implement their annotation style.
Something to think for next iteration (or over weekend) ;)