Should use freezed string constant here. #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Dec 7, 2011
Should use freezed string constant here.
sikachu
added a commit
to sikachu/rails
that referenced
this pull request
Dec 7, 2011
Snowman ☃ has been melted, now it's time to unfreeze those constants This refers to the discussion in commit 12be0a5 from pull request rails#3895.
This was referenced Dec 7, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I investigated other issue, I found this one.
We should use freezed string constant here.
Some string literals is used repeatedly.