Querying association with unscope(:where) from instance removes conditions

[dvandersluis]

Related to #38811. Trying to access an association of an AR instance where the association unscopes where no longer raises an exception, but still removes association conditions from the query.

Steps to reproduce

class Post < ActiveRecord::Base
  has_many :comments, -> { unscope(:where) }
end

class Comment < ActiveRecord::Base
  belongs_to :post

  default_scope { where(locale: :en) }
end

post = Post.create!
post.comments << Comment.create!(locale: nil)
post.comments.to_sql #=> SELECT "comments".* FROM "comments"

See https://gist.github.com/dvandersluis/86eb48649747c763dd06fb1bc35a4321 for a failing test.

Expected behavior

post.comments.to_sql should return

SELECT "comments".* FROM "comments" WHERE "comments"."post_id" = 1

Actual behavior

Unscopes association where clause

SELECT "comments".* FROM "comments"

System configuration

Rails version: 6.0.3

Ruby version: 2.6.2

[dvandersluis]

I'd be happy to try to fix it if someone can point me in the right direction of where the unscope is applied. 😄

[kamipo]

I had also tried to fix it in #38929, but some tests expects to unscope required conditions for now.

[dvandersluis]

@kamipo maybe those tests don't make sense then?

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.

[dvandersluis]

@kamipo i saw #38929 was merged does that mean this was fixed?

[rails-bot]

This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails team are limited, and so we are asking for your help.
If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open.
Thank you for all your contributions.