Ensure attribute decorations are always inherited #39468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, attribute decorations were not inherited by a subclass if they were added to the parent class after the subclass had added its own attribute decorations. This was due to the way attribute decorations were stored in an append-only `class_attribute`. This commit changes the way attribute decorations are stored to ensure they are always inherited.
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
May 29, 2020
This is a common `class_attribute` implementation issue (e.g. rails#39467, rails#39468, rails#38871). For now, we should take care of the change propagation by themselves if we want to ensure the propagation after the `class_attribute` are accessed in subclasses. Fixes rails#20678.
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 14, 2020
jonathanhefner
added a commit
to jonathanhefner/rails
that referenced
this pull request
Jun 14, 2020
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Closing in favor of #39487. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, attribute decorations were not inherited by a subclass if they were added to the parent class after the subclass had added its own attribute decorations. This was due to the way attribute decorations were stored in an append-only
class_attribute. This commit changes the way attribute decorations are stored to ensure they are always inherited.Splitting this off from #38871.