Use COMPONENT_ROOT as app_root when present in test unit reporting.

[simi]

Currently running test via bundle bin/test command provides wrong rerun command.

bin/test home/retro/code/oss/rails/actionpack/test/controller/url_for_test.rb:357

There are two problems:

1. it strips leading / in path (thanks to have Rails.root nil in here)
   

   rails/railties/lib/rails/test_unit/reporter.rb

   Lines 53 to 55 in 00c2d3e

   	def relative_path_for(file)
   	file.sub(/^#{app_root}\/?/, "")
   	end

2. full path instead of relative one is used

Rails.root is being re-defined in tools/test.rb, but it is already too late when this happens. Instead of hacking Rails.root I have decided to enhance app_root in test_unit/reporter.rb.

before

[retro@retro  actionpack (master *$=)]❤ bin/test test/controller/url_for_test.rb:357
Run options: --seed 63991
                                               
# Running:     

F                                                                                              
                                                                                               
Failure:                                      
AbstractController::Testing::UrlForTest#test_params_option [/home/retro/code/oss/rails/actionpack/test/controller/url_for_test.rb:360]:
Expected: "/c/a?domain=foo&id=1"   
  Actual: "/c/a"
                                               
                                                                                               
bin/test home/retro/code/oss/rails/actionpack/test/controller/url_for_test.rb:357

after

[retro@retro  actionpack (master *$=)]❤ bin/test test/controller/url_for_test.rb:357
Run options: --seed 63991
                                               
# Running:     

F                                                                                              
                                                                                               
Failure:                                      
AbstractController::Testing::UrlForTest#test_params_option [/home/retro/code/oss/rails/actionpack/test/controller/url_for_test.rb:360]:
Expected: "/c/a?domain=foo&id=1"   
  Actual: "/c/a"
                                               
                                                                                               
bin/test test/controller/url_for_test.rb:357

[eugeneius]

Thanks for looking into this! I had noticed it too but never got around to investigating. ❤️

The reporter is used by applications, so it's a bit weird for it to know about COMPONENT_ROOT, which is for Rails' internal use only.

How about allowing app_root to be injected in the same way as executable?

rails/tools/test.rb

Line 23 in ed1d583

Rails::TestUnitReporter.executable = "bin/test"

[simi]

How about allowing app_root to be injected in the same way as executable?

done @eugeneius

[eugeneius]

Thanks! 🙌